Skip to content

Conversation

@ajhuh-mdb
Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb commented Nov 19, 2024

DESCRIPTION

For reviewer: You just need to check that these commented strings don't appear in the pages and that the text between them seems to apply only to Compass (and not Atlas). Feel free to reach out to me if you have any questions. Apologies for the chunky review!

In the copybara script, we've set a regex that looks for the following starting and ending string:

.. BEGIN-COMPASS-ONLY

* compass-exclusive content * 

.. END-COMPASS-ONLY

That way, content that doesn't apply to Atlas Data Explorer will not be copied over.

Also removed several outdated version mentions.

STAGING

Verifying that the commented strings don't appear in the pages:

JIRA

https://jira.mongodb.org/browse/DOCSP-45459

BUILD LOG

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

@netlify
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for docs-compass ready!

Name Link
🔨 Latest commit b09eeb4
🔍 Latest deploy log https://app.netlify.com/sites/docs-compass/deploys/673e60187f3c320008e1ff84
😎 Deploy Preview https://deploy-preview-696--docs-compass.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@kennethdyer kennethdyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ajhuh-mdb, LGTM!

@ajhuh-mdb ajhuh-mdb merged commit 451b9d1 into mongodb:master Nov 22, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants